Improved the explanation about deployment + parameters.yml #8122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a little typo in your PR @javiereguiluz : change "insted" to "instead". |
yceruto
reviewed
Jul 7, 2017
deployment.rst
Outdated
| file as a template (that's why ``parameters.yml.dist`` must be committed and | ||
| deployed). | ||
|
|
||
| If your application uses environment variables insted of these parameters, you |
|
Fixed the typo. Thanks reviewers! |
xabbuh
reviewed
Jul 9, 2017
deployment.rst
Outdated
|
|
||
| This file should *not* be deployed, but managed through the automatic utilities | ||
| provided by Symfony. | ||
| B) Configure your Parameters File |
There was a problem hiding this comment.
we should add a label for the old headline
xabbuh
approved these changes
Jul 9, 2017
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Jul 11, 2017
…l (javiereguiluz) This PR was squashed before being merged into the 2.7 branch (closes #8122). Discussion ---------- Improved the explanation about deployment + parameters.yml This fixes #5158. As usual, the explanations in this article are a bit vague, because this is a generic deployment article and it contains no details (we have dedicated articles to explain those details). Commits ------- 186458c Improved the explanation about deployment + parameters.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5158.
As usual, the explanations in this article are a bit vague, because this is a generic deployment article and it contains no details (we have dedicated articles to explain those details).