10000 File example update by runawaycoin · Pull Request #8081 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

File example update #8081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

File example update #8081

wants to merge 2 commits into from

Conversation

runawaycoin
Copy link
Contributor

Update code example to highlight where the $file comes from in second example

@runawaycoin
File example update
41e99e1 
Update code example to highlight where the $file comes from in second example
OskarStark
OskarStark requested changes Jul 5, 2017
View reviewed changes
reference/forms/types/file.rst Outdated
@@ -52,7 +52,8 @@ be used to move the ``attachment`` file to a permanent location::
if ($form->isSubmitted() && $form->isValid()) {
$someNewFilename = ...

$form['attachment']->getData()->move($dir, $someNewFilename);
$file = $form['attachment']->getData()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the missing ; at the end

@runawaycoin
Update file.rst
85a0103 
Add ; at the end, sorry
@xabbuh xabbuh added this to the 2.7 milestone Jul 9, 2017
@xabbuh
Copy link
Member
xabbuh commented Jul 11, 2017

Thank you @runawaycoin.

xabbuh added a commit that referenced this pull request Jul 11, 2017
@xabbuh
minor #8081 File example update (runawaycoin)
8b4487b 
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #8081).

Discussion
----------

File example update

Update code example to highlight where the $file comes from in second example

Commits
-------

e7fb1a1 File example update
@xabbuh xabbuh closed this Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

@kalimerre kalimerre kalimerre approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@runawaycoin @xabbuh @OskarStark @kalimerre @carsonbot
0