10000 Revert a wrong change from #7877 by GuilhemN · Pull Request #8007 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Revert a wrong change from #7877 #8007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2017
Merged

Revert a wrong change from #7877 #8007

merged 1 commit into from
Jun 9, 2017

Conversation

GuilhemN
Copy link
Contributor
@GuilhemN GuilhemN commented Jun 8, 2017

As spotted by #7978, the short service syntax is about arguments and not tags, so this change was wrong.

@xabbuh xabbuh added this to the 3.3 milestone Jun 8, 2017
@xabbuh
Copy link
Member
xabbuh commented Jun 9, 2017

Thank you @GuilhemN.

@xabbuh xabbuh merged commit f3b1112 into symfony:3.3 Jun 9, 2017
xabbuh added a commit that referenced this pull request Jun 9, 2017
@xabbuh
minor #8007 Revert a wrong change from #7877 (GuilhemN)
a8b227e 
This PR was merged into the 3.3 branch.

Discussion
----------

Revert a wrong change from #7877

As spotted by #7978, the short service syntax is about arguments and not tags, so this change was wrong.

Commits
-------

f3b1112 Revert a wrong change from #7877
@GuilhemN GuilhemN deleted the revertwrongchange branch June 9, 2017 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@GuilhemN @xabbuh @carsonbot
0