pass only strings to loadUserByUsername() #7912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
reviewed
Jul 25, 2017
| if (null === $apiKey) { | ||
| return; | ||
| } | ||
|
|
||
| // if null, authentication will fail |
There was a problem hiding this comment.
This comment should be removed then.
xabbuh
added a commit
that referenced
this pull request
Jul 26, 2017
xabbuh
added a commit
that referenced
this pull request
Aug 1, 2017
* 2.8: [#8211] minor reword Reword Update language.rst Mention lazy loading for Doctrine event listeners Documented the WebProfilerBundle configuration Typo fixed in a doctrine docs [#8245] link text directly Link to '"creating a reproducer" in "reporting a bug" Removed an extra line Updated xml config [Form] [RepeatedType] Update "type" default value Fixed entity manager service name [#7912] remove obsolete comment Removed tabs in 2.8 docs Removed tabs in 2.7 docs Added docs for "date" and "number_format" Twig options
xabbuh
added a commit
that referenced
this pull request
Aug 1, 2017
* 3.2: [#8211] minor reword Reword Update language.rst Mention lazy loading for Doctrine event listeners Documented the WebProfilerBundle configuration Add pipe to dump command Update event_dispatcher.rst Typo fixed in a doctrine docs [#8245] link text directly Link to '"creating a reproducer" in "reporting a bug" Removed an extra line Updated xml config applying comment from @wouterj [Form] [RepeatedType] Update "type" default value Fixed entity manager service name [#7912] remove obsolete comment Removed tabs in 2.8 docs Removed tabs in 2.7 docs Added docs for "date" and "number_format" Twig options Added docs for the cache:pool:clear command
xabbuh
added a commit
that referenced
this pull request
Aug 1, 2017
* 3.3: (28 commits) [#8211] minor reword Reword Update language.rst Mention lazy loading for Doctrine event listeners Documented the WebProfilerBundle configuration Fixed usage of default configuration in PHP Some typos Add pipe to dump command Update event_dispatcher.rst Typo fixed in a doctrine docs [#8245] link text directly Link to '"creating a reproducer" in "reporting a bug" Removed an extra line Updated xml config applying comment from @wouterj [Form] [RepeatedType] Update "type" default value Adds a missing semicolon Added missing "," in encore/legacy-apps doc Fixed entity manager service name [#7912] remove obsolete comment ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes #7065 as since the change made there the
tokenkey can refer tonull.