Fix incoherent utf8mb4 collation in Doctrine setup #7904
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
May 15, 2017
There was a problem hiding this comment.
👍 I'm not an expert about this, but @marcverney's proposal makes a lot of sense to me.
|
Thank you @marcverney. |
xabbuh
added a commit
that referenced
this pull request
May 17, 2017
…erney) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #7904). Discussion ---------- Fix incoherent utf8mb4 collation in Doctrine setup The "Setting up the Database to be UTF8" section of the "Databases and the Doctrine ORM" page recommends the following default collation setup: - in MySQL's my.cnf: `collation-server = utf8mb4_general_ci` - and/or in Symfony's config.yml: `collate: utf8mb4_unicode_ci` As a reader I am confused by this difference. If there's a reason for it, I think it should be explained in the text. On the other hand, if there is none, both lines should probably reference `utf8mb4_unicode_ci` (reason: http://stackoverflow.com/a/766996/2516943). This PR intends to fix the latter case. Commits ------- c27f16a Fix incoherent ut8mb4 collation in Doctrine setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Setting up the Database to be UTF8" section of the "Databases and the Doctrine ORM" page recommends the following default collation setup:
collation-server = utf8mb4_general_cicollate: utf8mb4_unicode_ciAs a reader I am confused by this difference. If there's a reason for it, I think it should be explained in the text. On the other hand, if there is none, both lines should probably reference
utf8mb4_unicode_ci(reason: http://stackoverflow.com/a/766996/2516943). This PR intends to fix the latter case.