Fix framework instantiation in event-dispatcher #7889
Conversation
As the `$resolver` parameter was split up into `$controllerResolver` and `$argumentResolver`, the Framework instantiation call in this code example seems to be outdated and not in line with earlier steps taken in the tutorial.
|
@iltar you know a lot about this controller/argument resolver thing. Could you please check if this proposal is correct? Thanks! |
|
@GNi33 which tutorial are you referring to? This page seems to be up-to-date for the latest version (not the master at 4.0.0): https://symfony.com/doc/current/create_framework/http_kernel_controller_resolver.html |
|
@iltar I'm referring to the page about the Event Dispatcher in the Create Framework tutorial: The pull request changes the code block after the "The last step is the creation..." paragraph, where On the Seperation of concerns page, the instantiation is correct (second code block), as well as on the unit testing page. This is still present in 3.3, as well as in 3.4 |
|
Looks like the fix is to rename this to |
|
Yes, you are absolutely right, I missed that. Added it to the pull request. The matcher isn't being initialized as well here. Are these being left out deliberately in this example? |
|
Thank you @GNi33. |
This PR was squashed before being merged into the 3.2 branch (closes #7889). Discussion ---------- Fix framework instantiation in event-dispatcher As the `$resolver` parameter was split up into `$controllerResolver` and `$argumentResolver`, the Framework instantiation call in this code example seems to be outdated and not in line with earlier steps taken in the tutorial. Commits ------- bdd6791 Fix framework instantiation in event-dispatcher
As the
$resolverparameter was split up into$controllerResolverand$argumentResolver, the Framework instantiation call in this code example seems to be outdated and not in line with earlier steps taken in the tutorial.