8000 replace kernel.root_dir with kernel.project_dir by xabbuh · Pull Request #7829 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

replace kernel.root_dir with kernel.project_dir #7829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2017
Merged

replace kernel.root_dir with kernel.project_dir #7829

merged 2 commits into from
Apr 24, 2017

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Apr 20, 2017 •
edited
Loading

see #7768

linaori
linaori reviewed Apr 21, 2017
View reviewed changes
reference/configuration/doctrine.rst Outdated
@@ -398,7 +398,7 @@ The following block shows all possible configuration keys:
# the DBAL driverOptions option
options:
foo: bar
path: '%kernel.root_dir%/data/data.sqlite'
path: '%kernel.project_dir%ta/data.sqlite'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%kernel.project_dir%ta/ should be %kernel.project_dir%/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original was '%kernel.root_dir%/data/data.sqlite', so the new one should be '%kernel.project_dir%/app/data/data.sqlite'

javiereguiluz
javiereguiluz approved these changes Apr 24, 2017
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@javiereguiluz
Copy link
Member

Thanks Christian.

@javiereguiluz javiereguiluz merged commit 3c0ba11 into symfony:master Apr 24, 2017
javiereguiluz added a commit that referenced this pull request Apr 24, 2017
@javiereguiluz
minor #7829 replace kernel.root_dir with kernel.project_dir (xabbuh, …
6dc4742 
…javiereguiluz)

This PR was merged into the master branch.

Discussion
----------

replace kernel.root_dir with kernel.project_dir

see #7768

Commits
-------

3c0ba11 Fixed a path
b49da4a replace kernel.root_dir with kernel.project_dir
@xabbuh xabbuh deleted the issue-7768 branch April 24, 2017 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@linaori linaori linaori left review comments

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @javiereguiluz @linaori
0