8000 Rewriting the service container docs by weaverryan · Pull Request #7804 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Rewriting the service container docs #7804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Rewriting the service container docs #7804

wants to merge 4 commits into from

Conversation

weaverryan
Copy link
Member

Before updating the DI for 3.3, I wanted to rewrite some of the docs on 2.7.

wouterj
wouterj reviewed Apr 15, 2017
View reviewed changes
service_container.rst Outdated

What is a Service Container?
----------------------------
php bin/console debug:container
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing $ prefix

service_container.rst Outdated
Without a service container, you must manually create the object whenever
you need it::
Service ID Class name
------------------------------- -------------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reSt tables are:

=  =========
#  Something
=  =========
1  ....
2  ....
=  =========

service_container.rst Outdated
you need it::
Service ID Class name
------------------------------- -------------------------------------------------------------------
doctrine Doctrine\Bundle\DoctrineBundle\Registry
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to wrap these values inside literals, otherwise the backslashes won't be rendered

@weaverryan weaverryan deleted the di-minor-tweaks branch April 15, 2017 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj left review comments

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weaverryan @wouterj @carsonbot
0