8000 Documented short DI tag syntax by derrabus · Pull Request #7769 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Documented short DI tag syntax #7769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2017
Merged

Documented short DI tag syntax #7769

merged 1 commit into from
Apr 8, 2017

Conversation

derrabus
Copy link
Member
@derrabus derrabus commented Apr 8, 2017

This PR fixes #7248 and documents the short DI tag syntax for YAML files.

@derrabus
Copy link
Member Author
derrabus commented Apr 8, 2017

ping @xabbuh

@xabbuh xabbuh added this to the 3.3 milestone Apr 8, 2017
@xabbuh
Copy link
Member
xabbuh commented Apr 8, 2017

Thank you Alexander.

@xabbuh xabbuh merged commit f5b1f23 into symfony:master Apr 8, 2017
xabbuh added a commit that referenced this pull request Apr 8, 2017
@xabbuh
feature #7769 Documented short DI tag syntax (derrabus)
7849331 
This PR was merged into the master branch.

Discussion
----------

Documented short DI tag syntax

This PR fixes #7248 and documents the short DI tag syntax for YAML files.

Commits
-------

f5b1f23 Documented short DI tag syntax.
xabbuh added a commit that referenced this pull request Apr 8, 2017
@xabbuh
[#7769] tweak line break positions
4251e0e
xabbuh added a commit that referenced this pull request Apr 8, 2017
@xabbuh
[#7769] add missing versionadded directive
e47090e
@xabbuh
Copy link
Member
xabbuh commented Apr 8, 2017

After merging I realised that we should add a versionadded directive to not confuse users of older Symfony versions. So I added one in e47090e.

@derrabus derrabus deleted the 3.3-short-di-tags-in-yaml branch April 8, 2017 11:12
@GuilhemN GuilhemN mentioned this pull request Apr 30, 2017
Merged
javiereguiluz added a commit that referenced this pull request May 2, 2017
@javiereguiluz
minor #7863 Use the short tag syntax (GuilhemN)
ef36cc7 
This PR was merged into the master branch.

Discussion
----------

Use the short tag syntax

Continuation of #7769: use the short tag syntax where possible.

Commits
-------

5b596b9 Use the short tag syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

[DependencyInjection] Short tag syntax
4 participants
@derrabus @xabbuh @wouterj @carsonbot
0