[Validator] Add min/max amount of pixels to Image constraint #7756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2017
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jul 6, 2017
…traint (akeeman) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Add min/max amount of pixels to Image constraint | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#7756 Useful for asserting image sizes/areas in pixels, for instance to estimate processing work load. **This PR continues #22288**. I cleaned up my associated branch a while ago and found no way of restoring or re-linking. @fabpot: "Could you rename to [TOO_FEW_PIXEL_ERROR](https://github.com/akeeman/symfony/blob/9ab5263d712881f8aa24920631685d14acd3a19b/src/Symfony/Component/Validator/Constraints/Image.php#L28)? Same for the other constant?" This is done. @fabpot "Can you change the base to 3.4 instead of master and rebase on current 3.4? Thanks." This is done too. Commits ------- 9ab5263 add minimum and maximum amount of pixels to Image validator
HeahDude
approved these changes
Jul 29, 2017
|
symfony/symfony#23431 has been merged now. |
wouterj
added a commit
that referenced
this pull request
Sep 3, 2017
…raint (akeeman) This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #7756). Discussion ---------- [Validator] Add min/max amount of pixels to Image constraint Documentation for symfony/symfony#22288 Commits ------- 32f90ee Add minPixels and maxPixels constraints
wouterj
added a commit
that referenced
this pull request
Sep 3, 2017
|
Thank you for submitting & documenting these new constraint options! I've merged it in the 3.4 branch and added a version directive, indicating that this is new in Symfony 3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for symfony/symfony#22288