8000 Deprecated the SYMFONY__ variables by javiereguiluz · Pull Request #7738 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Deprecated the SYMFONY__ variables #7738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2017
Merged

Deprecated the SYMFONY__ variables #7738

merged 1 commit into from
Apr 15, 2017

Conversation

javiereguiluz
Copy link
Member

This fixes #7695.

HeahDude
HeahDude reviewed Apr 1, 2017
View reviewed changes
configuration/external_parameters.rst
The support of the special ``SYMFONY__`` environment variables was
deprecated in Symfony 3.3 and it will be removed in 4.0. Instead of
using those variables, define regular environment variables and get
their values using the ``%env(...)%`` syntax in your config files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"their value"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about this. I don't know which is the best option here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no doubt in French we definitely mean "each" when using "their". To me in this case, each environment variable has one value and not many, I've found many discussions on the web, looks like this confusion is global, see http://english.stackexchange.com/questions/131430/should-a-noun-after-the-determiner-their-take-in-the-form-of-singular-or-of-pl for a reference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"their values" sounds right to me

@xabbuh
Copy link
Member
xabbuh commented Apr 15, 2017

Thank you Javier.

@xabbuh xabbuh merged commit 880da48 into symfony:master Apr 15, 2017
xabbuh added a commit that referenced this pull request Apr 15, 2017
@xabbuh
minor #7738 Deprecated the SYMFONY__ variables (javiereguiluz)
7006c48 
This PR was merged into the master branch.

Discussion
----------

Deprecated the SYMFONY__ variables

This fixes #7695.

Commits
-------

880da48 Deprecated the SYMFONY__ variables
@javiereguiluz javiereguiluz deleted the fix_7695 branch May 24, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

@HeahDude HeahDude HeahDude left review comments

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DI] Deprecate the special SYMFONY__ environment variables
4 participants
@javiereguiluz @xabbuh @HeahDude @carsonbot
0