Coding standard example #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to remove the sentence or to be more precise :) |
|
Merged - and I agree with removing the sentence - commit and thoughts here: sha: 5367768 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discussion about Propel coding standards pointed that the example of the Sf2 coding standards is not correct as the
ifreturns.Another point that could need to be changed is the sentence
Use Symfony as the first namespace level. This is true for the Sf2 code itself but is wrong for all bundles that decide to follow the Sf2 CS (it should even be forbidden to use Symfony in this case. They should use their own vendor). What do you think about removing the sentence ?