Added a caution note about the LDAP injection attacks #7508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
HeahDude
approved these changes
Feb 27, 2017
xabbuh
reviewed
Mar 7, 2017
| The Security component escapes values provided when binding against an LDAP | ||
| server (likewise for the user provider). However, the LDAP component does | ||
| not provide any other escaping, so it's your responsibility to prevent | ||
| the LDAP injection attacks. |
There was a problem hiding this comment.
I would reword this a bit:
The Security component escapes provided input data when the LDAP user provider is used. However, the LDAP component itself does not provide any escaping yet. Thus, it's your responsibility to prevent LDAP injection attacks when using the component directly.
@javiereguiluz @csarrazi What do you think?
There was a problem hiding this comment.
@xabbuh your version is much better because it's easier to understand! Thanks.
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Mar 13, 2017
…viereguiluz) This PR was merged into the 2.8 branch. Discussion ---------- Added a caution note about the LDAP injection attacks After reading [this comment](#6795 (comment)) by @csarrazi I'm not sure which protection does the LDAP component offer and which one it doesn't ... so please, review this carefully. Thanks! Commits ------- dfc2867 Added a caution note about the LDAP injection attacks
xabbuh
added a commit
that referenced
this pull request
Mar 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading this comment by @csarrazi I'm not sure which protection does the LDAP component offer and which one it doesn't ... so please, review this carefully. Thanks!