8000 Moved the requirements file by javiereguiluz · Pull Request #7421 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Moved the requirements file #7421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Moved the requirements file #7421

wants to merge 5 commits into from

Conversation

javiereguiluz
Copy link
Member

No description provided.

@javiereguiluz
Copy link
Member Author

As expected, this failed:

Executing build hook...
    Could not open requirements file: [Errno 2] No such file or directory: './platform/requirements.txt'
    make: sphinx-build: Command not found
    make: *** [html] Error 127
    New python executable in /app/.virtualenv/bin/python
    Installing setuptools, pip, wheel...done.
    Requirement already satisfied: pip==9.0.1 in ./.virtualenv/lib/python2.7/site-packages
    Requirement already satisfied: wheel==0.29.0 in ./.virtualenv/lib/python2.7/site-packages
    make: Entering directory `/app/_build'
    sphinx-build -b html -c . -d ./doctrees   ../ ./html
    make: Leaving directory `/app/_build'

@javiereguiluz
Copy link
Member Author

No luck with the updated file path:

 Executing build hook...
    Could not open requirements file: [Errno 2] No such file or directory: '/app/.platform/requirements.txt'
    make: sphinx-build: Command not found
    make: *** [html] Error 127

Any other idea or should we close this?

@javiereguiluz
Copy link
Member Author

Another fail in the last attempt:

Could not open requirements file: [Errno 2] No such file or directory: '../.platform/requirements.txt'

@javiereguiluz
Copy link
Member Author

Another fail:

Could not open requirements file: [Errno 2] No such file or directory: './.platform/requirements.txt'

@javiereguiluz
Copy link
Member Author

@damz do you know if it's possible to more the requirements.txt file to the .platform/ directory and reference it in the .platform.app.yaml file. We've tried all kinds of file paths but none worked. Thanks!

@robfrawley
Copy link
Contributor

@javiereguiluz You can just use what I'd done in #7402

@javiereguiluz
Copy link
Member Author

... and it worked 🎉 @robfrawley thanks! You saved us!

@robfrawley
Copy link
Contributor
robfrawley commented Jan 27, 2017 •
edited
Loading

I still feel strongly that both Travis and Platform build using the same procedure (short of the special Travis flags): https://github.com/symfony/symfony-docs/pull/7402/files#diff-354f30a63fb0907d4ad57269548329e3R9 :-)

@javiereguiluz
Copy link
Member Author

Can we merge this? It's a minor change but it will help us remove this internal file. Thanks!

@xabbuh
Copy link
Member
xabbuh commented Mar 7, 2017

Thank you Javier.

xabbuh added a commit that referenced this pull request Mar 7, 2017
@xabbuh
minor #7421 Moved the requirements file (javiereguiluz)
0f5cf62 
This PR was squashed before being merged into the 2.7 branch (closes #7421).

Discussion
----------

Moved the requirements file

Commits
-------

4ce4b83 Moved the requirements file
@xabbuh xabbuh closed this Mar 7, 2017
@javiereguiluz javiereguiluz deleted the move_requirements branch May 24, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @robfrawley @xabbuh @carsonbot
0