Document that you can't pass empty strings to console options #7363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed |
|
I just added a commit that (I think) improves this situation, I think we should look at it before merging this. See symfony/symfony#21228 (comment). |
|
I'm putting this PR on hold because the genius @chalasr has managed to solve this issue. See symfony/symfony#21228 |
|
@javiereguiluz fixed on master only due to the potential too much important impact, this stays correct for older branches. |
|
@chalasr Thanks! Note to mergers: merge in all branches EXCEPT master. |
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Mar 1, 2017
…ions (javiereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- Document that you can't pass empty strings to console options Related to symfony/symfony#21215 Commits ------- 9666907 Document that you can't pass empty strings to console options
|
Reverted in 9232842 in the |
|
I'll look for adding a note to explain the behavior change in 3.3 asap today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to symfony/symfony#21215