10000 Document that you can't pass empty strings to console options by javiereguiluz · Pull Request #7363 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Document that you can't pass empty strings to console options #7363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2017
Merged

Document that you can't pass empty strings to console options #7363

merged 1 commit into from
Mar 1, 2017

Conversation

javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz mentioned this pull request Jan 14, 2017
Closed
@xabbuh
Copy link
Member
xabbuh commented Jan 14, 2017

👍

Status: Reviewed

@chalasr
Copy link
Member
chalasr commented Jan 15, 2017 •
edited
Loading

I just added a commit that (I think) improves this situation, I think we should look at it before merging this. See symfony/symfony#21228 (comment).
I was afraid that changing this behavior would give a lot of drawbacks, I'm sorry about that.

@javiereguiluz
Copy link
Member Author

I'm putting this PR on hold because the genius @chalasr has managed to solve this issue. See symfony/symfony#21228

@chalasr
Copy link
Member
chalasr commented Mar 1, 2017

@javiereguiluz fixed on master only due to the potential too much important impact, this stays correct for older branches.

@javiereguiluz
Copy link
Member Author

@chalasr Thanks!

Note to mergers: merge in all branches EXCEPT master.

@xabbuh xabbuh removed the On hold label Mar 1, 2017
@xabbuh
Copy link
Member
xabbuh commented Mar 1, 2017

Thank you Javier.

@xabbuh xabbuh merged commit 9666907 into symfony:2.7 Mar 1, 2017
xabbuh added a commit that referenced this pull request Mar 1, 2017
@xabbuh
minor #7363 Document that you can't pass empty strings to console opt…
185e886 
…ions (javiereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Document that you can't pass empty strings to console options

Related to symfony/symfony#21215

Commits
-------

9666907 Document that you can't pass empty strings to console options
xabbuh added a commit that referenced this pull request Mar 1, 2017
@xabbuh
Revert "minor #7363 Document that you can't pass empty strings to con…
9232842 
…sole options (javiereguiluz)"

This reverts commit 185e886, reversing
changes made to 402b96f.
@xabbuh
Copy link
Member
xabbuh commented Mar 1, 2017

Reverted in 9232842 in the master branch.

@chalasr
Copy link
Member
chalasr commented Mar 1, 2017

I'll look for adding a note to explain the behavior change in 3.3 asap today

@javiereguiluz javiereguiluz deleted the option_empty_string branch May 24, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @xabbuh @chalasr @carsonbot
0