[Console] Document how to exclude messages from output using SymfonyStyle #7360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da29e85 to
31a2a44
Compare
javiereguiluz
approved these changes
Apr 15, 2017
There was a problem hiding this comment.
@chalasr I liked this contribution a lot ... but I wanted to reword it slightly to better explain the stdout and stderr differences because stderr is still very confusing and a lot of developers think it's only useful to output error messages.
|
@javiereguiluz You did right, it was a bit unclear. Thanks for that! |
|
Any other review for this before merging it? Thanks! |
HeahDude
approved these changes
Apr 25, 2017
console/style.rst
Outdated
| If you create a ``SymfonyStyle`` instance with an ``OutputInterface`` object | ||
| that is not an instance of :class:`Symfony\\Component\\Console\\Output\\ConsoleOutputInterface`, | ||
| the ``getErrorStyle()`` method will have no effect and the returned object | ||
| will still output to the standard output instead of the error output. |
There was a problem hiding this comment.
"will still write" to avoid the repetition?
|
It's merged! Thanks @chalasr. |
javiereguiluz
added a commit
that referenced
this pull request
Apr 28, 2017
…ing SymfonyStyle (chalasr, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [Console] Document how to exclude messages from output using SymfonyStyle This adds documentation for symfony/symfony#20586, any suggestion will be really welcomed. Commits ------- a5c5524 Minor fix ff0ccde Reworded the description 31a2a44 Document how to exclude irrelevant messages from command output using SymfonyStyle
|
and thank you @javi 83CF ereguiluz :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds documentation for symfony/symfony#20586, any suggestion will be really welcomed.