-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update deployment.rst #7319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment.rst #7319
Conversation
deployment.rst
Outdated
@@ -54,7 +54,8 @@ Using Source Control | |||
If you're using source control (e.g. Git or SVN), you can simplify by having | |||
your live installation also be a copy of your repository. When you're ready | |||
to upgrade it is as simple as fetching the latest updates from your source | |||
control system. | |||
control system. A common approach for this in Git is, to tag your release and | |||
check out the Git tag on deployment (see `Git Tagging`_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jepster is tag checkout more common or popular than pull master branch? I think it depend on methodology. I met both approach and I can't say that one of them is much more popular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dominikhajduk Checking out the master branch is safer. Since you can rollback more clear to a previous release tag in case of failure. Git tags are the standard in module releases in the Drupal project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking out the master branch is safer. Since you can rollback more clear to a previous release tag in case of failure.
Exactly. That's why I have doubts if checkout tag instead of checkout master and just pull new version from origin should be proposed here. Of course we both agree that tag should be created anyway.
Then let's propose the proper way. ;)
Dominik Hajduk <notifications@github.com> schrieb am Fr., 6. Jan. 2017
19:01:
… ***@***.**** commented on this pull request.
------------------------------
In deployment.rst <#7319>:
> @@ -54,7 +54,8 @@ Using Source Control
If you're using source control (e.g. Git or SVN), you can simplify by having
your live installation also be a copy of your repository. When you're ready
to upgrade it is as simple as fetching the latest updates from your source
-control system.
+control system. A common approach for this in Git is, to tag your release and
+check out the Git tag on deployment (see `Git Tagging`_).
@jepster <https://github.com/jepster>
Checking out the master branch is safer. Since you can rollback more clear
to a previous release tag in case of failure.
Exactly. That's why I have doubts if checkout tag instead of checkout
master and just pull new version from origin should be proposed here. Of
course we both agree that tag should be created anyway.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7319>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAmW0jnLoLCBXUGKBglWktBx8PButdtBks5rPoF9gaJpZM4Lbp7P>
.
|
@jepster Version from http://symfony.com/doc/current/deployment.html is fine for me.
Maybe just: "as fetching the latest updates" > "as pulling the latest updates" or "as checkout the latest updates". |
Thank you @jepster. |
No description provided.