8000 Update deployment.rst by jepster · Pull Request #7319 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Update deployment.rst #7319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update deployment.rst #7319

wants to merge 2 commits into from

Conversation

jepster
Copy link
Contributor
@jepster jepster commented Jan 5, 2017

No description provided.

deployment.rst Outdated
@@ -54,7 +54,8 @@ Using Source Control
If you're using source control (e.g. Git or SVN), you can simplify by having
your live installation also be a copy of your repository. When you're ready
to upgrade it is as simple as fetching the latest updates from your source
control system.
control system. A common approach for this in Git is, to tag your release and
check out the Git tag on deployment (see `Git Tagging`_).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jepster is tag checkout more common or popular than pull master branch? I think it depend on methodology. I met both approach and I can't say that one of them is much more popular.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dominikhajduk Checking out the master branch is safer. Since you can rollback more clear to a previous release tag in case of failure. Git tags are the standard in module releases in the Drupal project.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jepster

Checking out the master branch is safer. Since you can rollback more clear to a previous release tag in case of failure.

Exactly. That's why I have doubts if checkout tag instead of checkout master and just pull new version from origin should be proposed here. Of course we both agree that tag should be created anyway.

@jepster
Copy link
Contributor Author
jepster commented Jan 6, 2017 via email

@dominikhajduk
Copy link
Contributor

@jepster Version from http://symfony.com/doc/current/deployment.html is fine for me.

If you're using source control (e.g. Git or SVN), you can simplify by having your live installation also be a copy of your repository. When you're ready to upgrade it is as simple as fetching the latest updates from your source control system.

Maybe just: "as fetching the latest updates" > "as pulling the latest updates" or "as checkout the latest updates".
But this is just my opinion and someone from core reviewers should decide.

@xabbuh xabbuh added this to the 2.7 milestone Jul 9, 2017
@xabbuh
Copy link
Member
xabbuh commented Sep 15, 2017

Thank you @jepster.

xabbuh added a commit that referenced this pull request Sep 15, 2017
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #7319).

Discussion
----------

Update deployment.rst

Commits
-------

324641b Minor reword
01291bc Update deployment.rst
@xabbuh xabbuh closed this Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4E60
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0