8000 A few minor improvements by bocharsky-bw · Pull Request #7113 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

A few minor improvements #7113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2016
Merged

A few minor improvements #7113

merged 2 commits into from
Nov 10, 2016

Conversation

bocharsky-bw
Copy link
Contributor

No description provided.

javiereguiluz
javiereguiluz approved these changes Nov 4, 2016
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

xabbuh
xabbuh reviewed Nov 5, 2016
View reviewed changes
doctrine/associations.rst
@@ -365,7 +365,7 @@ Of course, if you know up front that you'll need to access both objects, you
can avoid the second query by issuing a join in the original query. Add the
following method to the ``ProductRepository`` class::

// src/AppBundle/Entity/ProductRepository.php
// src/AppBundle/Repository/ProductRepository.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other chapters (doctrine/repository.rst, security/entity_provider.rst, testing/doctrine.rst), we have the repository classes in the Entity subnamespace. We should either update them as well or keep this example as is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best_practices/configuration.rst on other hand also uses the Repository namespace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to keep entities and repositories separately is a better option. Let's use the Repository namespace like in best practices. I'll push more changes

@xabbuh
Copy link
Member
xabbuh commented Nov 5, 2016

👍

1 similar comment
@wouterj
Copy link
Member
wouterj commented Nov 7, 2016

👍

@wouterj
Copy link
Member
wouterj commented Nov 10, 2016

Thanks a lot for fixing this inconsistency in the docs, Victor! It's now merged in.

@wouterj wouterj merged commit 0226bbc into symfony:2.7 Nov 10, 2016
wouterj added a commit that referenced this pull request Nov 10, 2016
@wouterj
minor #7113 A few minor improvements (bocharsky-bw)
cda1757 
This PR was merged into the 2.7 branch.

Discussion
----------

A few minor improvements

Commits
-------

0226bbc Rename 'Entity' to 'Repository' in namespaces for repository classes
68a6ff4 A few minor improvements
@bocharsky-bw bocharsky-bw deleted the patch-6 branch November 10, 2016 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bocharsky-bw @xabbuh @wouterj @javiereguiluz @carsonbot
0