8000 Update cache.rst by andreybolonin · Pull Request #7079 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Update cache.rst #7079

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Update cache.rst #7079

wants to merge 2 commits into from

Conversation

andreybolonin
Copy link
Contributor

No description provided.

javiereguiluz
javiereguiluz reviewed Nov 21, 2016
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I must be 👎 to the main change proposed by this pull request.

components/cache.rst Outdated
@@ -70,6 +70,14 @@ Now you can create, retrieve, updated and delete items using this cache pool::

// remove the cache item
$cache->deleteItem('stats.num_products');

Or you can use redis-based cache, instantiate :class:`Symfony\\Component\\Cache\\Adapter\\RedisAdapter`::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to not add this Redis example here. Why? Because in the "Basic usage" part of the components we display a "Hello World" example ... something very simple to give a glimpse of the features of that component. This example should be moved to the other articles that explain each of the cache types available.

Copy link
Contributor Author

Choose a reason f 8000 or hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@xabbuh
Copy link
Member
xabbuh commented Nov 28, 2016

@andreybolonin I think I agree with Javier here. Can you make the requested changes?

Status: Needs work

javiereguiluz
javiereguiluz approved these changes Feb 14, 2017
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh
Copy link
Member
xabbuh commented Mar 3, 2017

Thank you @andreybolonin.

xabbuh added a commit that referenced this pull request Mar 3, 2017
@xabbuh
minor #7079 Update cache.rst (andreybolonin, javiereguiluz)
1faced9 
This PR was submitted for the 3.1 branch but it was merged into the 3.2 branch instead (closes #7079).

Discussion
----------

Update cache.rst

Commits
-------

e4033a4 Removed the example about Redis
1f370ca Update cache.rst
@xabbuh xabbuh closed this Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andreybolonin @xabbuh @javiereguiluz @HeahDude @carsonbot
0