[DoctrineBridge] Document the new entityClass option
#7057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
commented
Oct 13, 2016
|
|
||
| **type**: ``string`` **default**: ``null`` | ||
|
|
||
| The fully-qualified class name (FQCN) of the entity to get the repository used for making the query to determine |
There was a problem hiding this comment.
I don't like this sentence very much. Any hint on how to rephrase it better ? 😄
There was a problem hiding this comment.
Maybe
The fully-qualified class name (FQCN) of the entity for which to get the repository used to determine the uniqueness
? Or just keep it as is for consistency
There was a problem hiding this comment.
Here is a proposal that says exactly the same but in a different order:
By default, the query performed to ensure the uniqueness uses the repository of
the current class instance. However, in some cases, such as when using Doctrine
inheritance mapping, you need to execute the query in a different repository.
Use this option to define the fully-qualified class name (FQCN) of the Doctrine
entity associated with the repository you want to use.
There was a problem hiding this comment.
@javiereguiluz : Perfect ! I'll update this PR in the minute. Thank you 🎉
fc063f2 to
8e4e47a
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Oct 14, 2016
…ed by the UniqueEntity validator (ogizanagi) This PR was merged into the 3.2-dev branch. Discussion ---------- [DoctrineBridge] Add a way to select the repository used by the UniqueEntity validator | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12573, #4087, #12977 | License | MIT | Doc PR | symfony/symfony-docs#7057 This is a cherry pick of #12977 on ~~2.8~~ 3.2 branch, as it is clearly a new feature, even if it was primary introduced in order to fix an inappropriate behavior that might be considered as a bug. Commits ------- 00d5459 [Doctrine] [Bridge] Add a way to select the repository used by the UniqueEntity validator
symfony-splitter
pushed a commit
to symfony/doctrine-bridge
that referenced
this pull request
Oct 14, 2016
…ed by the UniqueEntity validator (ogizanagi) This PR was merged into the 3.2-dev branch. Discussion ---------- [DoctrineBridge] Add a way to select the repository used by the UniqueEntity validator | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12573, #4087, #12977 | License | MIT | Doc PR | symfony/symfony-docs#7057 This is a cherry pick of #12977 on ~~2.8~~ 3.2 branch, as it is clearly a new feature, even if it was primary introduced in order to fix an inappropriate behavior that might be considered as a bug. Commits ------- 00d5459 [Doctrine] [Bridge] Add a way to select the repository used by the UniqueEntity validator
8e4e47a to
a9c2fc2
Compare
|
PR updated according to @javiereguiluz 's suggestion. The PR on the code repository has been merged too. |
entityClass optionentityClass option
|
👍 |
|
👍 |
wouterj
added a commit
that referenced
this pull request
Nov 10, 2016
…(ogizanagi) This PR was merged into the master branch. Discussion ---------- [DoctrineBridge] Document the new `entityClass` option Waiting for symfony/symfony#15002 to be merged. Commits ------- a9c2fc2 [DoctrineBridge] Document the new `entityClass` option
wouterj
added a commit
that referenced
this pull request
Nov 10, 2016
|
Thanks @ogizanagi! Prefect PR! I've moved the versionadded directives directly after the title, as this is consistent with the versionadded directives in form types options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for symfony/symfony#15002 to be merged.