8000 Update page_creation.rst by paolovas · Pull Request #7012 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Update page_creation.rst #7012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update page_creation.rst #7012

wants to merge 1 commit into from

Conversation

paolovas
Copy link

missing <?php

@paolovas
Copy link
Author

missing <?php

@javiereguiluz
Copy link
Member

@paolovas thanks for reporting this. You are right and those opening tags are missing.

However, instead of a "bug", this is considered a "feature" of the docs. It was decided a while ago to remove all the opening and closing PHP tags in the examples of the docs. In the past we've received some issues and some pull requests similar to this one and they were always rejected for not considering those tags strictly necessary for the code snippets shown in the docs.

The good news is that we added this feature to Symfony so you get an error message when the opening tag is missing.

For these reasons, I'm closing this pull request as "won't fix". I'm sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paolovas @javiereguiluz @carsonbot
0