8000 Improved the Homestead article by javiereguiluz · Pull Request #6831 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Improved the Homestead article #6831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improved the Homestead article #6831

wants to merge 1 commit into from

Conversation

javiereguiluz
Copy link
Member

This finishes #6762.

The change in line 14 is proposed because, strictly speaking, the slowness is caused by Homestead/Vagrant/Virtualization and not Symfony.

Before merging this, we'd new a review from other real Homestead users. Thanks!

@javiereguiluz javiereguiluz mentioned this pull request Aug 3, 2016
Closed
@wouterj
Copy link
Member
wouterj commented Aug 3, 2016

👎 for the type tip:

  • laravel is the default, specifying it as type will only cause confusion
  • The issue here is related to NGINX Configuration #6005 , only /web/app.php is executed using the PHP FPM, all other PHP files are not executed. I think the core problem here is that homestead doesn't have a generic php type that'll just serve all PHP files available in the directory.
  • The issue is not related to Symfony or Symfony components, it's just about Homestead features (e.g. Homestead currently is only focused on Laravel and Symfony frameworks, not standalone PHP projects using components).

@javiereguiluz
Copy link
Member Author

The reasons to close this as "won't fix" seem very strong 😄 Anyone wants to rebate Wouter's comments? Thanks.

@javiereguiluz
Copy link
Member Author

Closing it because Wouter's reasons are truly compelling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @wouterj @carsonbot
0