fix dumper default representation #6650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I think you're correct. We decided to only document the static API, so let's also use that in the descriptions as well. Status: reviewed /cc @xabbuh we may want to get the argument values in sync in Symfony core? |
|
👍 @wouterj Would be nice. But I have no idea how to do that without breaking BC (you could argue that technically the spaces don't matter but people seem to rely on it). |
|
Thank you @jamyouss. |
xabbuh
added a commit
that referenced
this pull request
Jun 20, 2016
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #6650). Discussion ---------- fix dumper default representation Hi, The default representation of dumper when using `Yaml` class is expanded: `public static function dump($array, $inline = 2, $indent = 4, $flags = 0)` May be i'm wrong because the `$inline` argument is different in `Yaml` (default inline=2 so expanded) and `Dumper` (default inline=0 so inline) class. So it depend to which class we refer to. Commits ------- def7c99 fix dumper default representation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The default representation of dumper when using
Yamlclass is expanded:public static function dump($array, $inline = 2, $indent = 4, $flags = 0)May be i'm wrong because the
$inlineargument is different inYaml(default inline=2 so expanded) andDumper(default inline=0 so inline) class. So it depend to which class we refer to.