[Validator] Clarify behaviour of Blank and NotBlank validator #6030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets |
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets |
8000
davidfuhr
changed the title
Clearify behaviour of Blank and NotBlank validator
[Validator] Clarify behaviour of Blank and NotBlank validator
Dec 17, 2015
| :doc:`/reference/constraints/NotBlank`. But be careful as ``NotBlank`` is | ||
| *not* strictly the opposite of ``Blank``. Emtpy array and strictly | ||
| ``false`` are considered blank by the ``NotBlank`` validator but not by the | ||
| ``Blank`` validator. |
There was a problem hiding this comment.
This is related to the fact how most validators treat empty strings and null values (see #4244). Maybe we can clarify this a bit?
weaverryan
added a commit
that referenced
this pull request
Jul 20, 2017
|
Thanks @davidfuhr! Merged at sha: df3cdef into 2.7 and tweaked at sha: 713c3cc |
xabbuh
added a commit
that referenced
this pull request
Jul 20, 2017
* 3.2: [#8195] fix requirement checker binary Simplified the requirements article [#6030] Simplifying and showing code Clearify behaviour of Blank and NotBlank validator [#5838] Tweaking comment - the phpdoc policy is not concrete Update standards to match actual practices Updated the Requirements article for Symfony 3.2 Updated the Requirements article for Symfony 2.8
xabbuh
added a commit
that referenced
this pull request
Jul 20, 2017
* 3.3: [#8195] fix requirement checker binary Simplified the requirements article [#6030] Simplifying and showing code Clearify behaviour of Blank and NotBlank validator [#5838] Tweaking comment - the phpdoc policy is not concrete Update standards to match actual practices Updated the requirements article for Smyfony 3.3 Updated the Requirements article for Symfony 3.2 Updated the Requirements article for Symfony 2.8
xabbuh
added a commit
that referenced
this pull request
Jul 20, 2017
* 3.4: [#8195] fix requirement checker binary Simplified the requirements article [#6030] Simplifying and showing code Clearify behaviour of Blank and NotBlank validator [#5838] Tweaking comment - the phpdoc policy is not concrete Update standards to match actual practices Updated the Requirements article for Symfony 3.4 Updated the requirements article for Smyfony 3.3 Updated the Requirements article for Symfony 3.2 Updated the Requirements article for Symfony 2.8
weaverryan
added a commit
that referenced
this pull request
Jul 21, 2017
* origin/3.3: [#8195] fix requirement checker binary Simplified the requirements article [#6030] Simplifying and showing code Clearify behaviour of Blank and NotBlank validator [#5838] Tweaking comment - the phpdoc policy is not concrete Update standards to match actual practices Updated the requirements article for Smyfony 3.3 Updated the Requirements article for Symfony 3.2 Updated the Requirements article for Symfony 2.8 removed Charles Updated the Core Team information added CVE 2017-11365 added URL where to ask for a CVE identifier add missing choices_as_values options Update usage.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.