8000 [2.8] Add "How to Use Multiple Guard Authenticators" cookbook documentation by marek-pietrzak-tg · Pull Request #5886 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[2.8] Add "How to Use Multiple Guard Authenticators" cookbook documentation #5886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[2.8] Add "How to Use Multiple Guard Authenticators" cookbook documentation #5886

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bad8468
Add "How to Use Multiple Guard Authenticators" cookbook documentation
marek-pietrzak-tg Nov 12, 2015
95135ae
Remove obsolete lines
marek-pietrzak-tg Nov 12, 2015
eeeb57b
Add missing pattern to php configuration
marek-pietrzak-tg Nov 12, 2015
37fccf8
Add missing blank lines
marek-pietrzak-tg Nov 17, 2015
ea3c900
Apply changes for comments raised during review
marek-pietrzak-tg Feb 10, 2016
a2ca764
Add versionadded
marek-pietrzak-tg Feb 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing blank lines
  • Loading branch information
@marek-pietrzak-tg
marek-pietrzak-tg committed Feb 10, 2016
commit 37fccf8360ad3d6bc02b63835df8f0779c98c2e8
2 changes: 2 additions & 0 deletions cookbook/security/multiple_guard_authenticators.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ method should be called when an anonymous user hits a page that requires authent

Multiple authenticators with shared entry point
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to how we capitalise headlines this should be "Multiple Authenticators with a Shared Entry Point"

-----------------------------------------------

Let's have an example of two authenticators: one based on login form, another one on facebook login.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing empty line before this line

Both authenticators entry points redirect user to the same login page.
However, in your configuration you have to explicitly say which entry point you want to use.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We avoid the first person perspective in the docs. Thus, I would reword this paragraph to something like the following:

Sometimes you want to offer your users different authentication mechanisms like a form login and a Facebook login while both entry points redirect the user to the same login page. However, [...]

Expand Down Expand Up @@ -75,6 +76,7 @@ There is one limitation with this approach - you have to use exactly one entry p

Multiple authenticators with separate entry points
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple Authenticators with separate Entry Points

--------------------------------------------------

Let's now have an example of two different authenticators: one based on login form, another one on an API token.< 755A /td>
When user hits secured area he should be redirected to the login page.
Also when user hits an API endpoint, he should get a relevant API response.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace "Also when user hits[...]" with "But when a user hits [...]". We also use the gender-neutral form in the docs, please replace "he should get a relevant API response" with "they should get [...]".

Expand Down
0