Update example for method requirements #5776
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example was not doing what the text said it did, as it did not have two routes with the same url but different methods. Updated all four examples (annotations, yaml, xml and php)
8000
|
This is a duplicate, a PR with this code change already exists... let me have a look.... |
|
It has something in common with #5201, but in a reverse way 😄 |
|
OK, I see that in 2.3 this was changed from something similar to what I am suggesting to the current example. I see in the comments of that PR that this was done to give an example of a route that accepted several methods. I agree this is OK, but then you would need to change the text associated with this example, because what it describes is not what you see in the example. Let me try to change the text so that the explanation and the example say the same thing and I will submit a new commit |
|
Probably I will better send a new PR, I am closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example was not doing what the text said it did, as it did not have two routes with the same url but different methods. Updated all four examples (annotations, yaml, xml and php)