8000 Improved "Community Reviews" page by webmozart · Pull Request #5660 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Improved "Community Reviews" page #5660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Improved "Community Reviews" page #5660

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9be495a
Simplified/improved wording
webmozart Aug 28, 2015
77e57a3
Added example on PR IDs
webmozart Aug 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added example on PR IDs
  • Loading branch information
@webmozart
webmozart committed Aug 28, 2015
commit 77e57a3b78b208f873f13c3ff873e504f56c70e8
11 changes: 9 additions & 2 deletions contributing/community/reviews.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,22 @@ Pick a pull request from the `PRs in need of review`_ and follow these steps:

Take your project from step 3 and test whether the PR works properly.
Replace the Symfony project in the ``vendor`` directory by the code in the
PR by running the following Git commands. Insert the PR ID for the ``<ID>``
placeholders:
PR by running the following Git commands. Insert the PR ID (that's the number
after the ``#`` in the PR title) for the ``<ID>`` placeholders:

.. code-block:: text

$ cd vendor/symfony/symfony
$ git fetch origin pull/<ID>/head:pr<ID>
$ git checkout pr<ID>

For example:

.. code-block:: text

$ git fetch origin pull/15723/head:pr15723
$ git checkout pr15723

Now you can test the project against the code in the PR.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe link to http://symfony.com/doc/current/contributing/code/tests.html here?


#. **Update the PR Status**
Expand Down
0