8000 [Validator] added BIC validator by mvhirsch · Pull Request #5623 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Validator] added BIC validator #5623

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[Validator] added BIC validator #5623

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
238e201
[Validator] added BIC validator
mvhirsch Aug 12, 2015
8b04d1b
[Validator] fixed typo in description. refs #5623
mvhirsch Aug 12, 2015
6726882
[Validator] added BIC to constraints index. refs #5623
mvhirsch Aug 12, 2015
51126fa
[Validator] move bic to iban on index. refs #5623
mvhirsch Aug 13, 2015
b69f48d
[Validator] fixed typos according to notes. refs #5623
mvhirsch Aug 14, 2015
f952885
[Validator] fixed default annotation method and some typos. refs #5623
mvhirsch Aug 18, 2015
8ca96a4
[Validator] removed Acme from namespace. refs #5623
mvhirsch Aug 24, 2015
0543699
[Validator] added Bic to map.rst.inc
mvhirsch Aug 24, 2015
6bbfaf3
[Validator] fixed typo backtick. refs #5623
mvhirsch Aug 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Validator] move bic to iban on index. refs #5623
  • Loading branch information
@mvhirsch
mvhirsch committed Aug 13, 2015
commit 51126fa26ba5ccbe8017c5e541cf05a062f34896
2 changes: 1 addition & 1 deletion reference/constraints.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ Validation Constraints Reference
constraints/Currency
constraints/Luhn
constraints/Iban
constraints/Bic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be added to reference/constraints.map.rst.inc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, but I can't find such file. Did you mean reference/constraints/map.rst.inc instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion. That's indeed the file I meant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But let's do that in another PR, which is based on 2.3. For now, only update the newly added code examples

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean updating the code examples, right? And yes, I agree with you then.

constraints/Isbn
constraints/Issn
constraints/Bic

constraints/Callback
constraints/Expression
Expand Down
0