10000 Updated the article about data collectors by javiereguiluz · Pull Request #5592 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Updated the article about data collectors #5592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2015
Merged

Updated the article about data collectors #5592

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1de079
Updated the article about data collectors
javiereguiluz Aug 3, 2015
e3a80a4
Implemented all suggestions
javiereguiluz Aug 3, 2015
93bd994
Tweaks and fixes
javiereguiluz Aug 19, 2015
69bd677
Fixed some issues
javiereguiluz Sep 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweaks and fixes
  • Loading branch information
@javiereguiluz
javiereguiluz committed Sep 23, 2015
commit 93bd994239f4c23023045f3a74b24f02f548c95c
13 changes: 0 additions & 13 deletions cookbook/profiler/data_collector.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,7 @@ block and set the value of two variables called ``icon`` and ``text``:

.. code-block:: jinja
<<<<<<< HEAD
{{ include('@App/data_collector/icon.svg') }}
=======
{{ include('@WebProfiler/Icon/my_collector.svg') }}
>>>>>>> Implemented all suggestions
You are encouraged to use the latter technique for your own toolbar panels.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always put the recommended method before other methods. Can you please move this one before the data URL?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, but this article is for Symfony 2.3. In that version, the recommendation is to use base64 and <img>. Once this article is merged, I'll send a new PR for 2.7 with lots of changes and modern recommendations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think even 2.3 docs should advocate the modern recommendations. We still maintain that version, so it's not frozen back in the time.


Expand All @@ -204,23 +200,14 @@ must also define additional blocks:
{% endset %}

{# the 'link' value is now set to 'true', which allows the user to click
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should addd a note sayign it is the default, and so you don't need to change the value of the variable here

<<<<<<< HEAD
on it to access the web profiler panel. Since 'true' is the default
=======
on it to access to the web profiler panel. Since 'true' is the default
>>>>>>> Implemented all suggestions
value, you can omit the 'link' parameter entirely #}
{{ include('@WebProfiler/Profiler/toolbar_item.html.twig', { link: true }) }}
{% endblock %}

{% block head %}
<<<<<<< HEAD
{# Optional, you can here link to or define your own CSS and JS contents #}
{# {{ parent() }} to keep the default styles #}
=======
{# Optional, here you can link to or define your own CSS and JS contents #}
{# Use {{ parent() }} to keep the default styles #}
>>>>>>> Implemented all suggestions
{% endblock %}

{% block menu %}
Expand Down
0