8000 2.3 by ThomasLandauer · Pull Request #5569 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

2.3 #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

2.3 #5569

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8700975
Changed <meta http-equiv> to HTML5's <meta charset>
ThomasLandauer Jun 28, 2015
87e2c1e
Note about nesting blocks and {% endblock NAME %}
ThomasLandauer Jun 30, 2015
6ae94e9
Removed unnecessary(?) YAML hint
ThomasLandauer Jul 2, 2015
cd009c7
Fixed typo
ThomasLandauer Jul 2, 2015
526ead0
Another typo
ThomasLandauer Jul 2, 2015
0875f78
Merge pull request #3 from ThomasLandauer/ThomasLandauer-patch-3
ThomasLandauer Jul 28, 2015
cbc3e26
Merge pull request #4 from ThomasLandauer/ThomasLandauer-patch-4
ThomasLandauer Jul 28, 2015
8e5813c
Merge pull request #2 from ThomasLandauer/ThomasLandauer-patch-2
ThomasLandauer Jul 28, 2015
826a463
Merge pull request #1 from ThomasLandauer/ThomasLandauer-patch-1
ThomasLandauer Jul 28, 2015
eed20da
Typo: Removed comma
ThomasLandauer Jul 28, 2015
d893965
Merge pull request #5 from ThomasLandauer/ThomasLandauer-patch-1
ThomasLandauer Jul 28, 2015
52dcecd
Update templating.rst
ThomasLandauer Jul 28, 2015
8561baa
Added example for 'required' => false
ThomasLandauer Jul 28, 2015
01ab074
Fixed typo
ThomasLandauer Jul 29, 2015
f154514
Fixed file path
ThomasLandauer Jul 29, 2015
f57c14c
Merge pull request #6 from ThomasLandauer/ThomasLandauer-patch-5
ThomasLandauer Jul 29, 2015
e5fbbf7
Minor clarification
ThomasLandauer Jul 31, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed file path 
"app/Resources/views/Form/fields.html.twig" didn't work for me - see next code block: "form_theme form 'AppBundle:Form:fields.html.twig'"

If this change is correct, I guess it needs to be corrected multiple times on this page.
  • Loading branch information
@ThomasLandauer
ThomasLandauer committed Jul 29, 2015
commit f154514a5f5a2da8dedc534a69fed106be11963e
2 changes: 1 addition & 1 deletion cookbook/form/form_customization.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ can now re-use the form customization across many templates:

.. code-block:: html+jinja

{# app/Resources/views/Form/fields.html.twig #}
{# src/AppBundle/Resources/views/Form/fields.html.twig #}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks wrong to me. Best practices are to put templates in app/Resources/views

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyhow. My point is that the path used in the code exampled throughout this page is inconsistent! I don't know what the best practice is. If you don't want to change it here, then please change it in the next codeblock (and probably some others).

{% block integer_widget %}
<div class="integer_widget">
{% set type = type|default('number') %}
Expand Down
0