8000 Added mentions to some popular (and useful) Symfony bundles by javiereguiluz · Pull Request #5373 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Added mentions to some popular (and useful) Symfony bundles #5373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2015
Merged

Added mentions to some popular (and useful) Symfony bundles #5373

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
963d0a6
Added mentions to some popular (and useful) Symfony bundles
javiereguiluz Jun 9, 2015
bf4f3d6
Link to the official repository of the bundle.
javiereguiluz Jun 9, 2015
7370433
Fixed typos
javiereguiluz Jun 9, 2015
9dc8b8f
Fixed a minor grammar issue
javiereguiluz Jun 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed a minor grammar issue
  • Loading branch information
@javiereguiluz
javiereguiluz committed Jun 10, 2015
commit 9dc8b8f9b83957109ee034a09bec1a162fd5e685
2 changes: 1 addition & 1 deletion book/security.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ But who can you login as? Where do users come from?

.. tip::

If your application logs in users via a third-party service such as Google,
If your application logs users in via a third-party service such as Google,
Facebook or Twitter, check out the `HWIOAuthBundle`_ community bundle.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this bundle is abotu OAuth authentication. this is not specific to Twitter, Facebook or Google only. The wording should be improved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree. I think that mentioning Google, Facebook and Twitter explicitly is the best way to explain the purpose of this bundle.


.. _security-user-providers:
Expand Down
0