Rebase of #4989 #5099
Closed
Rebase of #4989 #5099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that changing the locale in the controller would not affect template rendering as the translator reads the request locale during the kernel.request event.
Closed
weaverryan
added a commit
that referenced
this pull request
Mar 20, 2015
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #5099). Discussion ---------- Rebase of #4989 Just a PR after rebasing #4989, which had some extra commits. This will be committed to the 2.3 branch. Commits ------- 006303d Moving index down to correct section 7281c53 [#4989] Language tweaks and making the example simpler 1ad8122 Remove useless setLocale() call and add code block with locale setter 43b2098 Finaly touches on translation locale setting note 79f5865 Review note about setting the translator locale in a controller. 3b136c8 Update translation.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a PR after rebasing #4989, which had some extra commits.
This will be committed to the 2.3 branch.