8000 Fixed the sample security voter to take into account the role hierarchy by javiereguiluz · Pull Request #5024 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Fixed the sample security voter to take into account the role hierarchy #5024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Fixed the sample security voter to take into account the role hierarchy #5024

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e6b10e9
Fixed the sample security voter to take into account the role hierarchy
javiereguiluz Feb 19, 2015
f9be868
Minor fixes in the sample code
javiereguiluz Feb 19, 2015
d68003c
'security.role_hierarchy' service is only defined when you actually u…
javiereguiluz Feb 21, 2015
75b35e0
Fixed the code sample when the application doesn't use the RoleHierarchy
javiereguiluz Feb 23, 2015
3dd747c
Fixed some grammar issues
javiereguiluz Feb 24, 2015
471ecda
Replaced TokenInterface by UserInterface
javiereguiluz Feb 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
'security.role_hierarchy' service is only defined when you actually u… 
…se a role hierarchy
  • Loading branch information
@javiereguiluz
javiereguiluz committed Feb 21, 2015
commit d68003c72c99965681aad615f0b4016d27d1576b
10 changes: 8 additions & 2 deletions best_practices/security.rst
8000
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ the same ``getAuthorEmail`` logic you used above:

private $roleHierarchy;

public function __construct(RoleHierarchyInterface $roleHierarchy)
public function __construct(RoleHierarchyInterface $roleHierarchy = null)
{
$this->roleHierarchy = $roleHierarchy;
}
Expand Down Expand Up @@ -189,6 +189,10 @@ the same ``getAuthorEmail`` logic you used above:
*/
private function userHasRole(TokenInterface $userToken, $roleName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should pass UserInterface here.

private function userHasRole(UserInterface $user, $roleName)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Fixed now. Thanks.

{
if (null === $this->roleHierarchy) {
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong. You should still use $userToken->getRoles() (which are the only reachable roles in this case).

}

foreach ($this->roleHierarchy->getReachableRoles($userToken->getRoles()) as $role) {
if ($roleName === $role->getRole()) {
return true;
Expand All @@ -208,7 +212,9 @@ To enable the security voter in the application, define a new service:
# ...
post_voter:
class: AppBundle\Security\PostVoter
arguments: ["@security.role_hierarchy"]
# beware that 'security.role_hierarchy' service is only defined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] that the 'security.role_hierarchy' [...]

# when the application's security config uses role hierarchy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] uses the role hierarchy

arguments: ["@?security.role_hierarchy"]
public: false
tags:
- { name: security.voter }
Expand Down
0