8000 Updated the best practices article for reusable bundles by javiereguiluz · Pull Request #5014 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Updated the best practices article for reusable bundles #5014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 26, 2015
Merged

Updated the best practices article for reusable bundles #5014

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a391563
Updated the best practices article for reusable bundles
javiereguiluz Feb 19, 2015
9981193
Minor fixes and added a cross link
javiereguiluz Feb 19, 2015
fa0b902
Fixed a minor syntax issue
javiereguiluz Jun 24, 2015
4276ced
Added back some information wrongly removed during the rebase
javiereguiluz Jun 24, 2015
776eaee
Reworded as a definition list
javiereguiluz Jun 24, 2015
286631d
Added a blank line beteen definition list items
javiereguiluz Jun 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed a minor syntax issue
  • Loading branch information
@javiereguiluz
javiereguiluz committed Jun 24, 2015
commit fa0b9029fa3d5a2f6cd2707fb83a307112a57750
4 changes: 2 additions & 2 deletions cookbook/bundles/best_practices.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,8 @@ The ``composer.json`` file should include at least the following metadata:
* ``license``, ``MIT`` is the preferred license for Symfony bundles, but you
can use any other value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should end with a semicolon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the way, using a definition list rather than an unordered list looks more reasonable to me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I've reworded it as a definition list. Thanks.

* ``autoload``, this information is used by Symfony to load the classes of the
bundle. The `PSR-4`_ autoload standard is recommended for modern bundles, but
`PSR-0`_ standard is also supported.
bundle. The `PSR-4`_ autoload standard is recommended for modern bundles, but
`PSR-0`_ standard is also supported.

In order to make it easier for developers to find your bundle, register it on
`Packagist`_, the official repository for Composer packages.
Expand Down
0