-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Added the documentation for the new Asset component #4987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9e1ac65
Added the documentation for the new Asset component
javiereguiluz bc3403a
Minor rewording
javiereguiluz e6e2ba4
Added a missing link reference
javiereguiluz 7312638
Tweaked documentation and added links to API methods/classes
javiereguiluz ac58089
Fixed a lot of errors and added an introduction
javiereguiluz 9c456e3
Moved the component documentation to its own folder
javiereguiluz 3c83243
Fixed some RST syntax issues
javiereguiluz 6f7a63e
Fixed RST syntax issues
javiereguiluz 6c2b2ee
Lots of fixes and rewordings
javiereguiluz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixed a lot of errors and added an introduction
- Loading branch information
commit ac58089ccd4e3a15b7657b9fc5ad7188add27cc4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I believe we're starting to quick with this more complex terminology. On IRC, we have lots of people that are often very confused with the term "asset" itself. Maybe we should first talk about that and show a very basic Asset component usage.
Btw, I would also propose to make the
Package
component default to theEmptyVersionStrategy
. I don't think many people need versioning at their first encounter. Then the example can be very simple:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, the real problem was the lack of an introduction for the asset. In ac58089 I briefly explain the benefits that the Asset component provides comparing it with no using any asset management.