Documented true regex #4879
Merged
Documented true regex #4879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes (symfony/symfony#11129) |
| Applies to | 2.7+ |
| Fixed tickets | - |
| The regex defaults to ``/^y/i``. | ||
|
|
||
| .. versionadded:: 2.7 | ||
| The regex argument was introduced in Symfony 2.7, before only answers |
There was a problem hiding this comment.
"[...] in Symfony 2.7. Before, only answers [...]"
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jan 25, 2015
This PR was merged into the 3.0-dev branch. Discussion ---------- Added i18n support to ConfirmationQuestion | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#4879 For instance, when creating a dutch cli app, you want this to be `j` (from "Ja") instead of the english `y`. Commits ------- 3cb280d Added i18n support to ConfirmationQuestion
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jan 25, 2015
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #11129). Discussion ---------- Added i18n support to ConfirmationQuestion | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | 8000 Doc PR | symfony/symfony-docs#4879 For instance, when creating a dutch cli app, you want this to be `j` (from "Ja") instead of the english `y`. Commits ------- c2f3f89 Added i18n support to ConfirmationQuestion
fabpot
added a commit
to symfony/console
that referenced
this pull request
Jan 25, 2015
This PR was merged into the 3.0-dev branch. Discussion ---------- Added i18n support to ConfirmationQuestion | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#4879 For instance, when creating a dutch cli app, you want this to be `j` (from "Ja") instead of the english `y`. Commits ------- 3cb280d Added i18n support to ConfirmationQuestion
|
Upstream PR is merged now |
|
This is perfect - well done and thanks! |
weaverryan
added a commit
that referenced
this pull request
Jan 30, 2015
This PR was merged into the 2.7 branch. Discussion ---------- Documented true regex | Q | A | --- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#11129) | Applies to | 2.7+ | Fixed tickets | - Commits ------- 6e6bae8 Small grammar-ish fix 050f7ce Documented true regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.