8000 Fixed typo by SofHad · Pull Request #4820 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Fixed typo #4820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixed typo #4820

wants to merge 2 commits into from

Conversation

SofHad
Copy link
Contributor
@SofHad SofHad commented Jan 13, 2015
Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets no

The word "performant" doesn't exist.

@stof
Copy link
Member
stof commented Jan 13, 2015

the optimized autoloader is not more powerful. It is faster (which is what the French word performant means)

@javiereguiluz
Copy link
Member

@SofHad thanks for reporting this error! Indeed, the performant word doesn't officially exist in English. We should reword that paragraph and talk about the great performance boost that provides that Composer option.

@SofHad
Copy link
Contributor Author
SofHad commented Jan 13, 2015

+1 for faster.
The --optimize-autoloader flag makes Composer's autoloader much faster and more efficient ...

@xabbuh
Copy link
Member
xabbuh commented Jan 13, 2015

"faster" sounds reasonable.

@wouterj
Copy link
Member
wouterj commented Jan 13, 2015

I like "[...] improves the performance of Composer's autoloader"

I also like "performant". As Symfony is a french built (and maintained) framework, we have some occurences for French words which should not cause much confusion (and aren't really important). However, it confused you enough to create a PR, so maybe we should remove it here :)

@SofHad
Update tools.rst
bf1d9ef 
replace powerful by faster
@SofHad
Copy link
Contributor Author
SofHad commented Jan 13, 2015

@wouterj
OK, this is done :)

@wouterj
Copy link
Member
wouterj commented May 22, 2015

I'm sorry @SofHad, but it seems like this PR was lost in our list. Meanwhile, someone else improved this sentence and the rest of the article: #5003 That's the reason I'm closing this one. I would still like to thank you for contributing!

@wouterj wouterj closed this May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SofHad @stof @javiereguiluz @xabbuh @wouterj
0