8000 [BestPractices] add missing comma by xabbuh · Pull Request #4734 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[BestPractices] add missing comma #4734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2015
Merged

[BestPractices] add missing comma #4734

merged 1 commit into from
Jan 2, 2015

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Jan 2, 2015
Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

@xabbuh xabbuh force-pushed the add- 8000 missing-comma branch from 761e311 to 46647c1 Compare January 2, 2015 14:44
@javiereguiluz
Copy link
Member

@xabbuh thanks for this fix! I wonder if we could be more agile for minor changes like this. Creating a pull request and adding the PR table for this seems a bit overkill to me.

@wouterj
Copy link
Member
wouterj commented Jan 2, 2015

@javiereguiluz PR tables are by any meaning not required for the documentations (just to lower the barrier). Unfortunately, we can't do anything about creating a PR...

@xabbuh
Copy link
Member Author
xabbuh commented Jan 2, 2015

Of course, people with write access could push directly, but that's bad since you won't get notified by these changes.

About the PR tables: I could have left it away, but it's faster to copy and paste it than thinking first if it was required or not. ;)

@wouterj wouterj merged commit 46647c1 into symfony:2.3 Jan 2, 2015
wouterj added a commit that referenced this pull request Jan 2, 2015
@wouterj
minor #4734 [BestPractices] add missing comma (xabbuh)
760a441 
This PR was merged into the 2.3 branch.

Discussion
----------

[BestPractices] add missing comma

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

46647c1 add missing comma and remove a serial comma
@xabbuh xabbuh deleted the add-missing-comma branch January 2, 2015 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @javiereguiluz @wouterj
0