8000 Fix typo: than in Twig => than Twig templates by ifdattic · Pull Request #4706 · symfony/symfony-docs · GitHub 8000
[go: up one dir, main page]
Skip to content

Fix typo: than in Twig => than Twig templates #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weaverryan merged 1 commit into from
Dec 29, 2014
Merged

Fix typo: than in Twig => than Twig templates #4706

weaverryan merged 1 commit into from
Dec 29, 2014

Conversation

@ifdattic
Copy link
Contributor
@ifdattic ifdattic commented Dec 29, 2014
Q A
Doc fix? yes
New docs? no
Applies to 2.3
Fixed tickets #4696

@ifdattic
Fix typo: than in Twig => than Twig templates
a8ec695 
| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets | #4696
stof
stof reviewed Dec 29, 2014
View reviewed changes
best_practices/templates.rst
Copy link
Member
@stof stof Dec 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say than Twig ones to avoid the repetition

Copy link
Contributor
@timglabisch timglabisch Dec 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

than Twig ones 👍

@weaverryan
Copy link
Member
weaverryan commented Dec 29, 2014

Cool! Yea, it sounds better this way. As to Stof's comment, I don't have a preference to which sounds better (template or "ones"), so I've kept it. Thanks Andrew!

@weaverryan weaverryan merged commit a8ec695 into symfony:2.3 Dec 29, 2014
weaverryan added a commit that referenced this pull request Dec 29, 2014
@weaverryan
minor #4706 Fix typo: than in Twig => than Twig templates (ifdattic)
0db36ea 
This PR was merged into the 2.3 branch.

Discussion
----------

Fix typo: than in Twig => than Twig templates

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets | #4696

Commits
-------

a8ec695 Fix typo: than in Twig => than Twig templates
@ifdattic ifdattic deleted the patch-5 branch December 30, 2014 09:25
@ifdattic
Copy link
Contributor Author
ifdattic commented Dec 30, 2014

Glad to help
< 716A /div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ifdattic @weaverryan @stof @timglabisch @wouterj
0