8000 GetResponse*Events stop after a response was set by Lumbendil · Pull Request #4532 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content
< 8000 div class="d-flex flex-column flex-md-row flex-items-start flex-md-items-center">

GetResponse*Events stop after a response was set #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 20, 2014
Merged

GetResponse*Events stop after a response was set #4532

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25e1069
Added notes specifying the propagation behaviour for kernel.view and …
Lumbendil Nov 29, 2014
d13943a
Add missing info about kernel.request event.
Lumbendil Nov 29, 2014
e729750
Changed phrasing to explain the effects off propagation stopping.
Lumbendil Nov 29, 2014
bebce0e
Fix incorrect event name.
Lumbendil Nov 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing info about kernel.request event.
  • Loading branch information
@Lumbendil
Lumbendil committed Nov 29, 2014
commit d13943a8029aab08ad943242b87c3fc6e17f04ad
5 changes: 5 additions & 0 deletions components/http_kernel/introduction.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,11 @@ return a ``Response`` directly, or to add information to the ``Request``
(e.g. setting the locale or setting some other information on the ``Request``
attributes).

.. note::

When setting a response for the ``kernel.view`` event, the propagation
is stopped, so the lower priority listeners on that event don't get called.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might cause some confusion. What about: "When setting a response for the kernel.view event, the propagation is stopped. This means listeners with lower priority won't be executed."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A full stop makes more sense to separate the two concepts. I'll change it.


.. sidebar:: ``kernel.request`` in the Symfony Framework

The most important listener to ``kernel.request`` in the Symfony Framework
Expand Down
6 changes: 3 additions & 3 deletions cookbook/service_container/event_listener.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ event is just one of the core kernel events::

.. note::

When setting a response for the ``kernel.view`` or ``kernel.exception``
events, the propagation is stopped, so the lower priority listeners on
that event don't get called.
When setting a response for the ``kernel.request``, ``kernel.view`` and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt this "or" instead oft "and"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact if you set it for kernel.request kernel.view won't even be triggered, and kernel.exception is exclusive with kernel.view (and is triggered after kernel.request) so I thought and was better.

Also, I'm refering to the set of the 3 events.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's due to how you would write this in german by I agree with @timglabisch here that "or" sounds more correct.

What do you think about rewording this a bit to make it more clear (sadly, I don't have a good idea right now).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, in german "or" would be more natural.

`kernel.request``, ``kernel.view`` and

you dont have to set kernel.request AND kernel.view AND ...., it's more like this is true for kernel.request || kernel.view | | ... :)

but "and" sounds ok for me, too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should indeed be OR. The event has to be either kernel.request, kernel.view or kernel.exception. It can't be kernel.request AND kernel.view AND kernel.exception at the same time, it's one of them. (but well, this is a very high technical view on this topic, I think both are ok to use)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree - should be OR - I've got it changed at sha: 5842f5c

Thanks!

``kernel.exception`` events, the propagation is stopped, so the lower
priority listeners on that event don't get called.

Now that the class is created, you just need to register it as a service and
notify Symfony that it is a "listener" on the ``kernel.exception`` event by
Expand Down
0