Updated Valid constraint reference #4381
Conversation
Revised PR symfony#4351 for 2.3 branch
|
👍 |
| This is the message that will be shown if the value is false. | ||
| If this constraint is applied to a property that holds an array of objects, | ||
| then each object in that array will be validated recursively if this option is set | ||
| to ``true``. |
There was a problem hiding this comment.
Maybe we can reword this a bit. For example:
If this constraint is enabled on a property that holds an array, each element in that array will be validated recursively.
What do you think?
There was a problem hiding this comment.
I think this is wrong, this sentence is about option deep.
Constraint can be applied to property, but not enabled and option deep can be enabled.
There was a problem hiding this comment.
Yeah, you're right. I should have written it like this:
If the constraint is applied on a property that holds an array and the
deepoption is enabled, each element in that array will be validated recursively.
There was a problem hiding this comment.
I've used the same wording as used for option traverse.
Personally I also don't like that sentence, and I think that description of both options should be changed (in separate PR?).
There was a problem hiding this comment.
Hi guys!
I've merged this in because it has some nice fixes and is at least 90% of the way there. So, let's talk about the wording here.
As I understand it (just from reading what we have here), these 2 options (traverse and deep) apply only if this is applied to a collection of objects. Is that correct?
Now, even though I can see the wording difference between traverse and deep, I don't really understand yet what the difference is. Does traverse mean "validate the objects" and deep means "validate the objects AND validate any objects embedded in those objects"?. Or does it mean something else? Does it make sense to set both traverse and deep to true at the same time, or is this redundant?
As you can see, I don't know yet exactly how this feature works. What I think we should do is include these in the main "Basic Usage" section so people can really see how they work and how they work together. This may mean we have a new sub-section called something like "Validating a collection of items".
What do you guys think?
There was a problem hiding this comment.
I'm actually not sure what they do. Maybe @webmozart can shed some light on it.
|
Great fixes - thanks @inso! I'll comment separately about the wording dicussions :). |
Revised PR #4351 for 2.3 branch