[Components][HttpKernel] outline implications of the kernel.terminate event #4224
8000Conversation
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | #4198 |
| @@ -472,6 +472,14 @@ you will trigger the ``kernel.terminate`` event where you can perform certain | |||
| actions that you may have delayed in order to return the response as quickly | |||
| as possible to the client (e.g. sending emails). | |||
|
|
|||
| .. caution:: | |||
|
|
|||
| You should use the ``kernel.terminate`` event with `PHP FPM`_ only. It | |||
There was a problem hiding this comment.
Maybe you should do more of a "Understand that if you ... then .... the event benefit is lost because it will be blocking... but it will still work.
There was a problem hiding this comment.
Yes, I agree with @cordoval - I think all we need to say is that you won't get the nice benefits unless you use PHP FPM. We might as well also mention that this is because the fastcgi_finish_request() PHP function is used, and only PHP FPM supports this.
|
@cordoval @weaverryan Sorry for the long delay. I updated the wording and added some more information. What do you think of it now? |
| .. caution:: | ||
|
|
||
| Internally, the HttpKernel makes use of the :phpfunction:`fastcgi_finish_request` | ||
| PHP function. This means that at the moment only the `PHP FPM`_ server |
There was a problem hiding this comment.
... at the moment, only the...
There was a problem hiding this comment.
I added commas before and after "at the moment". Is that correct?
There was a problem hiding this comment.
@wouterj Both? Or do you mean the first?
There was a problem hiding this comment.
I removed it again. Though I feel that the sentence looks a bit weird now.
|
It looks great now! Honestly, the sentence was pretty ok with no commas, with 2 commas and how it reads now. All very minor (and subjective to me) differences. But fun to discuss ;). Thanks guys! |
…rnel.terminate event (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Components][HttpKernel] outline implications of the kernel.terminate event | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #4198 Commits ------- c4f4588 outline implications of the kernel.terminate event
|
@weaverryan As long as you as a native speaker think that it is correct. :) |