-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Revamped the documentation about "Contributing Docs" #4223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
weaverryan
merged 10 commits into
symfony:2.3
from
javiereguiluz:revamp_contributing_doc
Sep 16, 2014
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
723603c
Revamped the documentation about "Contributing Docs"
javiereguiluz 53c3a16
Added missing link
javiereguiluz 4751eb9
lways use absolute links instead of relative for internal doc links
javiereguiluz 79375ae
Switched another relative link into an absolute reference
javiereguiluz 991ff6f
Added a note about not using relative internal links in the doc
javiereguiluz ff66e94
Added lots of fixes suggested by reviewers
javiereguiluz 15f3c94
Added another bunch of fixes suggested by reviewers
javiereguiluz 9bcd33d
More and more fixes and improvements
javiereguiluz baa06b5
Removed two highlight formats which are "experimental" and not
javiereguiluz 88ddbb1
Fixed all the errors found by Ryan
javiereguiluz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added lots of fixes suggested by reviewers
- Loading branch information
commit ff66e94a27c22a01b95e2f6360dcb95abc74da29
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -119,7 +119,8 @@ Markup format Use it to display | |
Adding Links | ||
~~~~~~~~~~~~ | ||
|
||
**Internal links** to other documentation pages use the following syntax: | ||
The most common type of links are **internal links** to other documentation pages, | ||
which use the following syntax: | ||
|
||
.. code-block:: rst | ||
|
||
|
@@ -135,23 +136,25 @@ The page name should not include the file extension (``.rst``). For example: | |
|
||
:doc:`/cookbook/configuration/environments` | ||
|
||
Although they are technically correct, avoid the use of relative internal links | ||
such as the following: | ||
The title of the linked page will be automatically used as the text of the link. | ||
If you want to modify that title, use this alternative syntax: | ||
|
||
.. code-block:: rst | ||
|
||
:doc:`controller` | ||
:doc:`Spooling Email </cookbook/email/spool>` | ||
|
||
:doc:`event_dispatcher/introduction` | ||
.. note:: | ||
|
||
:doc:`environments` | ||
Although they are technically correct, avoid the use of relative internal | ||
links such as the following: | ||
|
||
The title of the linked page will be automatically used as the text of the link. | ||
If you want to modify that title, use this alternative syntax: | ||
.. code-block:: rst | ||
|
||
.. code-block:: rst | ||
:doc:`controller` | ||
|
||
:doc:`Spooling Email </cookbook/email/spool>` | ||
:doc:`event_dispatcher/introduction` | ||
|
||
:doc:`environments` | ||
|
||
**Links to the API** follow a different syntax, where you must specify the type | ||
of linked resource (``namespace``, ``class`` or ``method``): | ||
|
@@ -178,15 +181,15 @@ New Features or Behavior Changes | |
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
If you're documenting a brand new feature or a change that's been made in | ||
Symfony2, you should precede your description of the change with a | ||
Symfony, you should precede your description of the change with a | ||
``.. versionadded:: 2.X`` directive and a short description: | ||
|
||
.. code-block:: text | ||
|
||
.. versionadded:: 2.3 | ||
The ``askHiddenResponse`` method was introduced in Symfony 2.3. | ||
|
||
You can also ask a question and hide the response. This is particularly... | ||
You can also ask a question and hide the response. This is particularly [...] | ||
|
||
If you're documenting a behavior change, it may be helpful to *briefly* describe | ||
how the behavior has changed. | ||
|
@@ -197,9 +200,9 @@ how the behavior has changed. | |
The ``include()`` function is a new Twig feature that's available in | ||
Symfony 2.3. Prior, the ``{% include %}`` tag was used. | ||
|
||
Whenever a new minor version of Symfony2 is released (e.g. 2.4, 2.5, etc), | ||
Whenever a new minor version of Symfony is released (e.g. 2.4, 2.5, etc), | ||
a new branch of the documentation is created from the ``master`` branch. | ||
At this point, all the ``versionadded`` tags for Symfony2 versions that have | ||
At this point, all the ``versionadded`` tags for Symfony versions that have | ||
reached end-of-life will be removed. For example, if Symfony 2.5 were released | ||
today, and 2.2 had recently reached its end-of-life, the 2.2 ``versionadded`` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you should remove the serial comma here |
||
tags would be removed from the new 2.5 branch. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of the linked resource