8000 Fixed code highlighting by wouterj · Pull Request #4215 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Fixed code highlighting #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2014
Merged

Fixed code highlighting #4215

merged 1 commit into from
Sep 15, 2014

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented Sep 9, 2014
Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets -

Double quoted strings are the only scalar style capable of expressing arbitrary strings, by using “\” escape sequences.

\w and \d are invalid escape sequences in Yaml, causing the Yaml highlighter to fail.

@stof
Copy link
Member
stof commented Sep 13, 2014

👍

@xabbuh
Copy link
Member
xabbuh commented Sep 13, 2014

👍 Would be nice if there was an option to let Sphinx raise a warning when it cannot properly highlight a code block for which it was expected.

@stof
Copy link
Member
stof commented Sep 13, 2014

I requested it: https://bitbucket.org/birkenfeld/sphinx/issue/1565/add-an-option-to-throw-a-warning-when

@xabbuh
Copy link
Member
xabbuh commented Sep 13, 2014

Thank you @stof

@weaverryan
Copy link
Member

Thanks guys!

@weaverryan weaverryan merged commit f4b5dc6 into 2.3 Sep 15, 2014
weaverryan added a commit that referenced this pull request Sep 15, 2014
@weaverryan
minor #4215 Fixed code highlighting (WouterJ)
8591b87 
This PR was merged into the 2.3 branch.

Discussion
----------

Fixed code highlighting

| Q   | A
| --- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | all
| Fixed tickets | -

 > Double quoted strings are the only scalar style capable of expressing arbitrary strings, by using “\” escape sequences.
 > - http://yaml.org/spec/1.1/#id904245

`\w` and `\d` are invalid escape sequences in Yaml, causing the Yaml highlighter to fail.

Commits
-------

f4b5dc6 Fixed code highlighting
@wouterj wouterj deleted the fix-highlih branch October 23, 2014 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wouterj @stof @xabbuh @weaverryan
0