[Book] consistent and complete config examples #4114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <access-control> | ||
| <rule path="^/cart/checkout" role="IS_AUTHENTICATED_ANONYMOUSLY" | ||
| <rule path="^/cart/checkout" | ||
| role="IS_AUTHENTICATED_ANONYMOUSLY" | ||
| requires_channel="https" /> |
There was a problem hiding this comment.
Can someone confirm that requires_channel is the right attribute (and note requires-channel)?
There was a problem hiding this comment.
it should be requires-channel (both work, but according to the Symfony XML standards, dashes should be used)
Make configuration examples in the book consistent throughout the different configuration formats. Also fixing several syntax issues.
|
WOW, another HUGE PR. I don't know how you get such a huge volume of changes :). Thanks as always @xabbuh! |
weaverryan
added a commit
that referenced
this pull request
Aug 16, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [Book] consistent and complete config examples | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Make configuration examples in the book consistent throughout the different configuration formats. Also fixing several syntax issues. Commits ------- 96fb64f [Book] consistent and complete config examples
weaverryan
added a commit
that referenced
this pull request
Aug 16, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [Components] consistent & complete config examples | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies t 8EFD o | all | Fixed tickets | Make configuration examples in the components section consistent throughout the different configuration formats. Also fixing several syntax issues. This is mainly the same that I did in #4114 for the book. Commits ------- d08da50 [Components] consistent & complete config examples
weaverryan
added a commit
that referenced
this pull request
Aug 25, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [Reference] consistent & complete config examples | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Make configuration examples in the reference section consistent throughout the different configuration formats. Also fixing several syntax issues. This follow #4114 and #4129. Commits ------- 01dc25c [Reference] consistent & complete config examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make configuration examples in the book consistent throughout the different configuration formats. Also fixing several syntax issues.