8000 Fixed typo in filesystem component by kohkimakimoto · Pull Request #4079 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Fixed typo in filesystem component #4079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kohkimakimoto
Copy link
Contributor

The makePathRelative method returns a path with a slash at end.
See this test case.

@weaverryan
Copy link
Member

Easy merge when you point to a test-case :). Thanks Kohki!

@weaverryan weaverryan merged commit 82d2903 into symfony:2.3 Aug 4, 2014
weaverryan added a commit that referenced this pull request Aug 4, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Fixed typo in filesystem component

The `makePathRelative` method returns a path with a slash at end.
See this [test case](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php#L793).

Commits
-------

82d2903 Fixed typo in filesystem component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0