-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
8000
[HttpFoundation] Added a switch to delete file after the response is send #3975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
weaverryan
merged 1 commit into
symfony:master
from
WybrenKoelmans:binaryresponse-delete-file-after-send
Aug 16, 2014
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -515,6 +515,13 @@ You can still set the ``Content-Type`` of the sent file, or change its ``Content | |
'filename.txt' | ||
); | ||
|
||
.. versionadded:: 2.6 | ||
The ``deleteFileAfterSend()`` method was introduced in Symfony 2.6. | ||
|
||
It is possible to delete the file after the request is send with the | ||
:method:`Symfony\\Component\\HttpFoundation\\BinaryFileResponse::deleteFileAfterSend` method. | ||
Please note that this will not work when the ``X-Sendfile`` header is set. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you must add a .. versionadded:: 2.6
The ``deleteFileAfterSend()`` method was introduced in Symfony 2.6. (of course, you need to change 2.6 to whatever version your code PR is merged) |
||
|
||
.. _component-http-foundation-json-response: | ||
|
||
Creating a JSON Response | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be
is sent
- but I'll change that :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I always mix those up