Varnish only takes into account max-age
#3936
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Varnish only takes into account max-age, Symfony by default returns Cache-Control: no-cache so Varnish caches it anyway. You need to specify:
```
if (beresp.http.Pragma ~ "no-cache" ||
beresp.http.Cache-Control ~ "no-cache" ||
beresp.http.Cache-Control ~ "private") {
return (hit_for_pass);
}
```
In order to avoid Varnish from caching content.
|
Wow, it looks like you're right (https://www.varnish-cache.org/docs/3.0/tutorial/increasing_your_hitrate.html#cache-control). What do you think about adding a little note in your comment that says that Varnish ignores the |
|
Done! |
| @@ -57,6 +57,13 @@ Symfony2 adds automatically: | |||
| // For Varnish < 3.0 | |||
| // esi; | |||
| } | |||
| /* By default Varnish ignores Cache-Control: nocache (https://www.varnish-cache.org/docs/3.0/tutorial/increasing_your_hitrate.html#cache-control), | |||
There was a problem hiding this comment.
could you please put the url on a new line? That way, people don't have to do the quirckly horizontal scroll & select thing to select the url.
|
This is an awesome find and a great note/addition. Thankss Gonzalo for it and the quick tweaks - we hope to see you back here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a
2FB5
subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Varnish only takes into account max-age, Symfony by default returns Cache-Control: no-cache so Varnish caches it anyway. You need to specify:
In order to avoid Varnish from caching content.