-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[RFR] Misc. minor fixes mostly related to formatting issues #3899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
79bf0a1
00b3d26
dee3180
0554cae
4641c66
9a71577
314c131
81fe666
6625ff2
2deb5d7
3b557a0
e871a32
b223417
03b83ba
d38f00e
2442839
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -176,17 +176,11 @@ instance, if you want to match both ``m.example.com`` and | |
|
||
return $collection; | ||
|
||
.. sidebar:: Using Service Parameters | ||
.. tip:: | ||
|
||
You can also use service parameters if you do not want to hardcode the | ||
hostname: | ||
|
||
.. tip:: | ||
|
||
Make sure you also include a default option for the ``domain`` placeholder, | ||
otherwise you need to include a domain value each time you generate | ||
a URL using the route. | ||
|
||
.. configuration-block:: | ||
|
||
.. code-block:: yaml | ||
|
@@ -242,6 +236,12 @@ instance, if you want to match both ``m.example.com`` and | |
|
||
return $collection; | ||
|
||
.. tip:: | ||
|
||
Make sure you also include a default option for the ``domain`` placeholder, | ||
otherwise you need to include a domain value each time you generate | ||
a URL using the route. | ||
|
||
.. _component-routing-host-imported: | ||
|
||
Using Host Matching of Imported Routes | ||
|
@@ -289,12 +289,12 @@ Testing your Controllers | |
You need to set the Host HTTP header on your request objects if you want to get | ||
past url matching in your functional tests. | ||
|
||
.. code-block:: php | ||
.. code-block:: php | ||
|
||
$crawler = $client->request( | ||
'GET', | ||
'/homepage', | ||
array(), | ||
array(), | ||
array('HTTP_HOST' => 'm.' . $client->getContainer()->getParameter('domain')) | ||
); | ||
$crawler = $client->request( | ||
'GET', | ||
'/homepage', | ||
array(), | ||
array(), | ||
array('HTTP_HOST' => 'm.' . $client->getContainer()->getParameter('domain')) | ||
); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now, the contents of the code block is no longer indented by four spaces, is it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The code block was wrongly indented. I "fixed" it ... but I forgot to reindent the |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -287,12 +287,12 @@ The new environment is now accessible via:: | |
|
||
.. note:: | ||
|
||
Some environments, like the ``dev`` environment, are never meant to be | ||
accessed on any deployed server by the general public. This is because | ||
certain environments, for debugging purposes, may give too much information | ||
about the application or underlying infrastructure. To be sure these environments | ||
aren't accessible, the front controller is usually protected from external | ||
IP addresses via the following code at the top of the controller: | ||
Some environments, like the ``dev`` environment, are never meant to be | ||
accessed on any deployed server by the general public. This is because | ||
certain environments, for debugging purposes, may give too much information | ||
about the application or underlying infrastructure. To be sure these environments | ||
aren't accessible, the front controller is usually protected from external | ||
IP addresses via the following code at the top of the controller: | ||
|
||
.. code-block:: php | ||
|
||
|
@@ -315,8 +315,12 @@ However, each environment caches its own set of files: | |
|
||
.. code-block:: text | ||
|
||
app/cache/dev - cache directory for the *dev* environment | ||
app/cache/prod - cache directory for the *prod* environment | ||
<your-project>/ | ||
├─ app/ | ||
│ ├─ cache/ | ||
│ │ ├─ dev/ # cache directory for the *dev* environment | ||
│ │ └─ prod/ # cache directory for the *prod* environment | ||
│ ├─ ... | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unicode trees! :) |
||
|
||
Sometimes, when debugging, it may be helpful to inspect a cached file to | ||
understand how something is working. When doing so, remember to look in | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will change the letters to numbers, did you make sure references to the list items are also updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I did my best to check if letter were reference. I found none.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javiereguiluz according to @xabbuh in the other thred, the bug was fixed by the indentation change, ot by the switch from
a)
to#.
. So you could try switching it back